Fix pre-commit hook to not stage unrelated working directory changes #683
+39
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update-links section was using `git diff --name-only` which captures ALL modified files in the working directory, not just files modified by the update-links script. This could accidentally stage files the user had modified but intentionally not staged for the current commit. Fix: Capture the list of already-modified files BEFORE running update-links, then only stage files that weren't already modified (i.e., files that became modified as a result of update-links). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
nearestnabors
requested review from
evantahler,
sdserranog,
teallarson and
torresmateo
evantahler
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The update-links section was using
git diff --name-onlywhich captures ALL modified files in the working directory, not just files modified by the update-links script. This could accidentally stage files the user had modified but intentionally not staged for the current commit.Test plan
🤖 Generated with Claude Code
Note
Ensures the
update-linksstep in.husky/pre-commitdoes not stage unrelated working changes.ALREADY_MODIFIEDfiles before runningpnpm update-links, then stages only newly modifiedapp/**/*.mdx|md|tsxfilesWritten by Cursor Bugbot for commit 4c5bf20. This will update automatically on new commits. Configure here.